[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned memory
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned memory slots |
|
Date: |
Thu, 01 Mar 2012 10:08:47 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
On 03/01/2012 10:03 AM, Avi Kivity wrote:
>>>
>>> - ram = memory_region_get_ram_ptr(mr) + section->offset_within_region;
>>> + ram = memory_region_get_ram_ptr(mr) + section->offset_within_region
>>> + delta;
>>
>> Am I crazy, or does this look wrong?
>
> Could be both. Why do you thing it is wrong?
Line wrapping makes it look like we are adding two lines, one line
ending in 'section->offset_within_region', and the next line starting
with 'delta;', which is a syntax error.
But without line wrapping, we are adding just one line with
'offset_within_region + delta;' at the end of that line.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature