[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v5 11/14] trace: [tracetool] Add error-reporting
From: |
Harsh Prateek Bora |
Subject: |
[Qemu-devel] [RFC PATCH v5 11/14] trace: [tracetool] Add error-reporting functions |
Date: |
Thu, 1 Mar 2012 18:55:37 +0530 |
From: Lluís Vilanova <address@hidden>
Signed-off-by: Lluís Vilanova <address@hidden>
Signed-off-by: Harsh Prateek Bora <address@hidden>
---
scripts/tracetool.py | 27 +++++++++++++++------------
1 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/scripts/tracetool.py b/scripts/tracetool.py
index dc93a1a..6cbbdd7 100755
--- a/scripts/tracetool.py
+++ b/scripts/tracetool.py
@@ -63,6 +63,13 @@ def get_format_descr(format_):
return ""
+def error_write(*lines):
+ sys.stderr.writelines(lines)
+
+def error(*lines):
+ error_write(*lines)
+ sys.exit(1)
+
######################################################################
# backend auto-registration and format compatibility
@@ -521,8 +528,9 @@ def main():
try:
opts, args = getopt.getopt(sys.argv[1:], "", long_options)
except getopt.GetoptError, err:
- # print help information and exit:
- print str(err) # will print something like "option -a not recognized"
+ # print help information and exit
+ # will print something like "option -a not recognized"
+ error_write(str(err)+"\n")
usage()
sys.exit(2)
for opt, arg in opts:
@@ -551,24 +559,19 @@ def main():
usage()
if format_ not in _formats:
- print "Unknown format: %s" % format_
- print
+ error_write("Unknown format: %s\n\n" % format_)
usage()
if backend not in _backends:
- print "Unknown backend: %s" % backend
- print
+ error_write("Unknown backend: %s\n\n" % backend)
usage()
if format_ == 'stap':
if binary == "":
- print '--binary is required for SystemTAP tapset generator'
- sys.exit(1)
+ error("--binary is required for SystemTAP tapset generator\n")
if not probeprefix and not targettype:
- print '--target-type is required for SystemTAP tapset generator'
- sys.exit(1)
+ error("--target-type is required for SystemTAP tapset generator\n")
if not probeprefix and not targetarch:
- print '--target-arch is required for SystemTAP tapset generator'
- sys.exit(1)
+ error("--target-arch is required for SystemTAP tapset generator\n")
if probeprefix == "":
probeprefix = 'qemu.' + targettype + '.' + targetarch
--
1.7.1.1
- [Qemu-devel] [RFC PATCH v5 00/14] Tracing Improvements, Simpletrace v2, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 06/14] trace: [tracetool] Process the "disable" event property, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 12/14] monitor: remove unused do_info_trace, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 14/14] scripts/simpltrace.py changes: Support simplettrace v2, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 05/14] trace: [tracetool] Add support for event properties, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 07/14] trace: [tracetool] Rewrite event argument parsing, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 11/14] trace: [tracetool] Add error-reporting functions,
Harsh Prateek Bora <=
- [Qemu-devel] [RFC PATCH v5 02/14] trace: [tracetool] Do not rebuild event list in backend code, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 08/14] trace: [tracetool] Make format-specific code optional with access to events, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 03/14] trace: [tracetool] Simplify event line parsing, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 13/14] Simpletrace v2: Handle var num of args, strings., Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 09/14] trace: [tracetool] Automatically establish available backends and formats, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 04/14] trace: [tracetool] Do not precompute the event number, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 10/14] trace: Provide a per-event status define for conditional compilation, Harsh Prateek Bora, 2012/03/01
- [Qemu-devel] [RFC PATCH v5 01/14] Converting tracetool.sh to tracetool.py, Harsh Prateek Bora, 2012/03/01