Re: [Qemu-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save

[Gerd Hoffmann]

> And the only user of screen_dump_filename is:
> 
> static void vga_save_dpy_update(DisplayState *ds,
>                                 int x, int y, int w, int h)
> {
>     if (screen_dump_filename) {
>         ppm_save(screen_dump_filename, ds->surface);

upstream/master this here:

          screen_dump_filename = NULL;

>     }
> }

> This seems to work, only tested with -vga qxl and in vga mode:

The corner case where this fails is when console switching is needed,
i.e. switch to monitor console via ctrl-alt-2, then type the screenshot
command there ...