Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

[Kevin Wolf]

Am 17.02.2012 20:21, schrieb Luiz Capitulino:
> It's emitted whenever the tray is moved by the guest or by HMP/QMP
> commands.
> 
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
>  QMP/qmp-events.txt |   18 ++++++++++++++++++
>  block.c            |   24 ++++++++++++++++++++++++
>  monitor.c          |    3 +++
>  monitor.h          |    1 +
>  4 files changed, 46 insertions(+), 0 deletions(-)
> 
> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> index 06cb404..9286af5 100644
> --- a/QMP/qmp-events.txt
> +++ b/QMP/qmp-events.txt
> @@ -26,6 +26,24 @@ Example:
>  Note: If action is "stop", a STOP event will eventually follow the
>  BLOCK_IO_ERROR event.
>  
> +DEVICE_TRAY_MOVED
> +-----------------
> +
> +It's emitted whenever the tray of a removable device is moved by the guest
> +or by HMP/QMP commands.
> +
> +Data:
> +
> +- "device": device name (json-string)

For me, a device name is something related to qdev. 'device' is a
misnomer consistently used in all QMP commands so far and we can't fix
it any more, but at least the documentation should clarify what is meant
(that's for a follow-up patch).

Kevin