Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors

[Juan Quintela]

Luiz Capitulino <address@hidden> wrote:
> The Monitor object is passed back and forth within the migration/savevm
> code so that it can print errors and progress to the user.
>
> However, that approach assumes a HMP monitor, being completely invalid
> in QMP.
>
> This commit drops almost every single usage of the Monitor object, all
> monitor_printf() calls have been converted into DPRINTF() ones.
>
> There are a few remaining Monitor objects, those are going to be dropped
> by the next commit.
>
> Signed-off-by: Anthony Liguori <address@hidden>
> Signed-off-by: Luiz Capitulino <address@hidden>

Basically only block-migration.c uses the monitor at all (rest of code
only pass around for block migration).  Block migration don't work vey
well (to put it midly) at the moment.

I agree with removing the parameter, and also the info if that is
required.

Later, Juan.