Re: [Qemu-devel] [PATCH] [m68k] Move helpers.h to helper.h

[Andreas Färber]

Am 13.02.2012 16:33, schrieb Lluís Vilanova:
> Provides a file naming scheme consistent with other targets.
> 
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
>  target-m68k/helper.c    |    2 +-
>  target-m68k/helper.h    |   54 
> +++++++++++++++++++++++++++++++++++++++++++++++
>  target-m68k/helpers.h   |   54 
> -----------------------------------------------
>  target-m68k/op_helper.c |    2 +-
>  target-m68k/translate.c |    6 +++--
>  5 files changed, 59 insertions(+), 59 deletions(-)
>  create mode 100644 target-m68k/helper.h
>  delete mode 100644 target-m68k/helpers.h

Please check your git options, it did not recognize that you're renaming
the file. Or did you also reformat it?

Is there any particular reason for these three patches beyond
aesthetics? Header names are purely target-specific choices here and do
not simplify, e.g., any Makefile logic.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg