Re: [Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows

[Gleb Natapov]

On Mon, Feb 06, 2012 at 07:09:42PM -0500, Kevin O'Connor wrote:
> On Mon, Feb 06, 2012 at 01:43:42PM -0200, Luiz Capitulino wrote:
> > "Kevin O'Connor" <address@hidden> wrote:
> > > On Fri, Feb 03, 2012 at 05:16:27PM -0200, Luiz Capitulino wrote:
> > > > On Fri, 03 Feb 2012 11:23:05 -0600
> > > > Michael Roth <address@hidden> wrote:
> > > > > I'd been tracking Gerd's QMP wakeup series as the s3 resolution we 
> > > > > need 
> > > > > for guest-suspend, is that still the case?
> > > > 
> > > > Yes. But now I remembered about a seabios bug with S3... Need to check 
> > > > if
> > > > it were already addressed.
> > > 
> > > I'm not aware of any recent S3 defects in SeaBIOS.  If there is a
> > > defect, please let me know.
> > > 
> > > (I am aware of recent discussions on SeaBIOS and it running the
> > > vgabios on s3-resume, but I would not classify that issue as a
> > > defect.)
> > 
> > The problem is that, the screen goes black after resuming from S3. Gleb
> > debugged it a bit and he said that it was caused by a change in seabios.
> > 
> > Please, take a look at the last three comments in this bz:
> > 
> >  https://bugzilla.redhat.com/show_bug.cgi?id=772614
> 
> Perhaps a semantic distinction, but I don't consider that to be a
> seabios defect.
> 
Non optimal default. The default didn't change BTW, but it was config
parameter before and we changed it for RHEL. Now config parameter is
gone.

> In any case, I don't think this was addressed.  Gerd published a patch
> that can address this in qemu:
> http://www.seabios.org/pipermail/seabios/2012-January/002944.html
> 
Strictly speaking the patch is incorrect since it introduces the file
for all architectures, but I do not think qemu is the right place to
tune SeaBIOS defaults. I propose this patch instead:
---

Run vgabios during S3 resume by default on QEMU. QEMU still able to modify
SeaBIOS behavior if it wishes so by providing etc/s3-resume-vga-init file.

Gleb Natapov <address@hidden>
diff --git a/src/optionroms.c b/src/optionroms.c
index 27cfffd..06db1c1 100644
--- a/src/optionroms.c
+++ b/src/optionroms.c
@@ -423,7 +423,7 @@ vga_setup(void)
 
     // Load some config settings that impact VGA.
     EnforceChecksum = romfile_loadint("etc/optionroms-checksum", 1);
-    S3ResumeVgaInit = romfile_loadint("etc/s3-resume-vga-init", 0);
+    S3ResumeVgaInit = romfile_loadint("etc/s3-resume-vga-init", 
!CONFIG_COREBOOT);
     ScreenAndDebug = romfile_loadint("etc/screen-and-debug", 1);
 
     if (CONFIG_OPTIONROMS_DEPLOYED) {
--
                        Gleb.