[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 21/27] qdev: fix off-by-one
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH v2 21/27] qdev: fix off-by-one |
Date: |
Sat, 4 Feb 2012 09:02:51 +0100 |
Integer properties did not work.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/qdev-properties.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index d69a987..debb37f 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -151,7 +151,7 @@ static void set_int8(Object *obj, Visitor *v, void *opaque,
error_propagate(errp, local_err);
return;
}
- if (value > prop->info->min && value <= prop->info->max) {
+ if (value >= prop->info->min && value <= prop->info->max) {
*ptr = value;
} else {
error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
@@ -259,7 +259,7 @@ static void set_int16(Object *obj, Visitor *v, void *opaque,
error_propagate(errp, local_err);
return;
}
- if (value > prop->info->min && value <= prop->info->max) {
+ if (value >= prop->info->min && value <= prop->info->max) {
*ptr = value;
} else {
error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
@@ -333,7 +333,7 @@ static void set_int32(Object *obj, Visitor *v, void *opaque,
error_propagate(errp, local_err);
return;
}
- if (value > prop->info->min && value <= prop->info->max) {
+ if (value >= prop->info->min && value <= prop->info->max) {
*ptr = value;
} else {
error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
--
1.7.7.6
- Re: [Qemu-devel] [PATCH v2 24/27] qdev: initialize properties via QOM, (continued)
- [Qemu-devel] [PATCH v2 26/27] omap_clk: convert to QOM, Paolo Bonzini, 2012/02/04
- [Qemu-devel] [PATCH v2 16/27] qdev: remove print/parse methods from LostTickPolicy properties, Paolo Bonzini, 2012/02/04
- [Qemu-devel] [PATCH v2 15/27] qdev: remove parse method for string properties, Paolo Bonzini, 2012/02/04
- [Qemu-devel] [PATCH v2 25/27] qdev: remove unused fields from PropertyInfo, Paolo Bonzini, 2012/02/04
- [Qemu-devel] [PATCH v2 21/27] qdev: fix off-by-one,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v2 09/27] qom: add object_resolve_path_type, Paolo Bonzini, 2012/02/04
- [Qemu-devel] [PATCH v2 27/27] omap: remove PROP_PTR properties, Paolo Bonzini, 2012/02/04
- [Qemu-devel] [PATCH v2 11/27] qom: fix canonical paths vs. interfaces, Paolo Bonzini, 2012/02/04
- [Qemu-devel] [PATCH v2 22/27] qdev: access properties via QOM, Paolo Bonzini, 2012/02/04