qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug
Date: Thu, 02 Feb 2012 18:29:20 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0

On 02/02/2012 06:03 PM, Anthony Liguori wrote:


Is this still needed with qom-upstream.14?  I fixed a bug on .14 that
involved child properties that was making device-del sometimes fail.

Not sure, I tried with .13 but, from the look of it, it should still be there. Regarding the .13->.14 diff:

- you need QTAILQ_FOREACH_SAFE in object_property_del_child.

- you need to check for the existence of the non-aliased name when accessing the alias table, because s390 does not have PCI.

If it is, what's your test case?

I check that the device disappears from "info qtree". I check with gdb that after object_unparent the refcount is zero.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]