qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/23] qom: use Type system to register all devi


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 00/23] qom: use Type system to register all devices
Date: Wed, 01 Feb 2012 14:10:58 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15

On 02/01/2012 01:55 PM, Peter Maydell wrote:
On 30 January 2012 21:16, Anthony Liguori<address@hidden>  wrote:
Patch 8/23 is an automated touch everything patch.

It's kind of awkward having a patch series that is both long (number
of patches) and wide (patches that require touching/conversion of
every device in the tree), because the length means it needs a long
review time on the list, and the width means it's going to conflict
with lots of other changes (and especially newly arriving device
models).

I could certainly split this into three parts.

But patches 0-8 aren't terribly meaningful outside of the context of patch 9.

And patch 9 by itself leaves the old infrastructure around which means that you would potentially need more patches like patch 9 in a future series.

So I don't think this series could really be trimmed by anything more than a couple patches and I don't see a huge advantage in doing that.

This sort of changes are the exception, not the common thing. Once this series is merged, things will go back to normal patch series wise.

Regards,

Anthony Liguori


-- PMM





reply via email to

[Prev in Thread] Current Thread [Next in Thread]