Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

[Paolo Bonzini]

On 01/31/2012 10:49 PM, Jan Kiszka wrote:
> >  Just make the methods that you want to override virtual with the default
> >  implementation and then make a KVMPIT that inherits from the PIT and
> >  then overrides whatever virtual functions it needs to.
>
> That doesn't sound like the proper design for this purpose. Rather, we
> have an abstract base class that both implementations are derived from.

Absolutely!

> If I'm not using QOM properly to achieve this, please tell me.

It looks good, besides the need to rebase to Anthony's "part 3" changes.

Paolo