[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/9] fdc: take side count into account
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/9] fdc: take side count into account |
|
Date: |
Tue, 31 Jan 2012 10:28:26 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Hervé Poussineau <address@hidden> writes:
> Markus Armbruster a écrit :
>> Hervé Poussineau <address@hidden> writes:
>>
>>> Floppies can be simple or double-sided. However, current code
>>> was only taking the common case into account (ie 2 sides).
>>
>> Impact?
>
> This repairs single-sided floppies
>
>> Are single sided floppies broken before the patch? How?
>
> Yes. For head > 0, wrong sector number is calculated, so data is
> read/written at wrong place on underlying block device.
>
> Fortunately, mostly nobody is still using single-sided floppies (only
> some 360 kB floppies are single-sided), so bug has been neglected
> since a long time.
Nice info, thanks. Best put it in the commit message.
[Qemu-devel] [PATCH v3 2/9] fdc: set busy bit when starting a command, Hervé Poussineau, 2012/01/23
[Qemu-devel] [PATCH v3 3/9] fdc: most control commands do not generate interrupts, Hervé Poussineau, 2012/01/23
[Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register, Hervé Poussineau, 2012/01/23
[Qemu-devel] [PATCH v3 4/9] fdc: handle read-only floppies (abort early on write commands), Hervé Poussineau, 2012/01/23
[Qemu-devel] [PATCH v3 7/9] fdc: check if media rate is correct before doing any transfer, Hervé Poussineau, 2012/01/23