Re: [Qemu-devel] [PATCH] GRLIB UART: Add RX channel

[Fabien Chouteau]

On 26/01/2012 14:55, Avi Kivity wrote:
> On 01/26/2012 03:45 PM, Fabien Chouteau wrote:
>> @@ -141,18 +219,19 @@ grlib_apbuart_write(void *opaque, target_phys_addr_t 
>> addr,
>>  static bool grlib_apbuart_accepts(void *opaque, target_phys_addr_t addr,
>>                                    unsigned size, bool is_write)
>>  {
>> -    return is_write && size == 4;
>> +    return size <= 4;
>>  }
> 
> Please drop this function.
> 
>>  
>>  static const MemoryRegionOps grlib_apbuart_ops = {
>>      .write = grlib_apbuart_write,
>> +    .read = grlib_apbuart_read,
>>      .valid.accepts = grlib_apbuart_accepts,
> 
> The default is to accept sizes 1-4, so you can just drop .valid.accepts
> and need not replace it with anything.

OK, thanks.

-- 
Fabien Chouteau