|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [RFC][PATCH] signrom: Speed up checksum calculation |
Date: | Mon, 23 Jan 2012 14:37:48 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15 |
On 01/23/2012 02:32 PM, Jan Kiszka wrote:
On 2012-01-23 21:08, Anthony Liguori wrote:On 01/23/2012 01:25 PM, Stefan Weil wrote:Am 23.01.2012 20:19, schrieb Jan Kiszka:On 2012-01-23 20:16, Stefan Weil wrote:Am 23.01.2012 19:38, schrieb Jan Kiszka:[snip]What about replacing the whole script by a python script? That would save about 6 more forks :-)I think we have no python dependency in the build system yet - while we have for awk. That was also the original reason to go for a shell script. If the situation changed, I would not vote against python, for sure. JanWe do. Even configure will fail now without Python: if ! has $python; then echo "Python not found. Use --python=/path/to/python" exit 1 fi QEMU depends on Python = Python 2 for QAPI, tracing and maybe more. See scripts/*.py.I've been thinking that we could potentially rewrite a large chunk (all?) of configure in python too since we have such a hard dependency now.Sounds almost like a GSoC project.
That's a good idea!
Or work for someone who did something nasty ;).
Shhh, don't tell any students that :-) Regards, Anthony Liguori
At least it's no afternoon hack when done properly. However, I will now write signrom.py. That's much shorter. Jan
[Prev in Thread] | Current Thread | [Next in Thread] |