Re: [Qemu-devel] [PATCH 0/2] Generic tick reinjection control

[Anthony Liguori]

On 01/23/2012 01:15 PM, Jan Kiszka wrote:
> QEMU currently supports lost tick compensation for the periodic RTC
> timer. It is controlled via -rtc driftfix=slew|none. However, the next
> periodic timer with compensation qualities is approaching: KVM's
> in-kernel PIT.
>
> A previous discussion [1] showed that we need to introduce per device
> control. And we likely also want a global default. Both features require
> a generic standardized way to specify the compensation mode.
>
> So this series lays the ground for that by adding a qdev property type
> to select from four possible lost tick compensation policies (see patch
> 1 one for details). And this new property is then applied on the RTC
> device.

Looks good.  I'll take this through my tree.

Now we can just set the appropriate globals in order to enable a default rtc 
policy of slew.

Regards,

Anthony Liguori

> [1] http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85339
>
> Jan Kiszka (2):
>    qdev: Introduce lost tick policy property
>    mc146818rtc: Use lost_tick_policy property
>
>   hw/mc146818rtc.c     |   26 +++++++++++++++++------
>   hw/qdev-properties.c |   55 ++++++++++++++++++++++++++++++++++++++++++++++++++
>   hw/qdev.h            |    7 ++++++
>   qemu-common.h        |    7 ++++++
>   sysemu.h             |    1 -
>   vl.c                 |   28 ++++++++++++++++++++----
>   6 files changed, 111 insertions(+), 13 deletions(-)