[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation
From: |
Hannes Reinecke |
Subject: |
Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation |
Date: |
Mon, 16 Jan 2012 14:59:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Thunderbird/3.1.8 |
On 01/16/2012 02:39 PM, Anthony Liguori wrote:
> On 01/13/2012 10:54 AM, Andreas Färber wrote:
>> Am 13.01.2012 12:19, schrieb Hannes Reinecke:
>>> + if (desc) {
>>> + trace_megasas_readl_reg("mmio", desc, retval);
>>> + } else {
>>> + trace_megasas_readl("mmio", addr, retval);
>>> + }
>>
>> Drop _reg version?
>>
>> Didn't review the SCSI bits. Patch is pretty large, too. ;)
>
> I have the same thought but it looks to be large because of the
> header and tracing file. I didn't see an obvious place to break it up.
>
> Although Hannes, if there is a way to break it up, that would
> certainly help review.
>
Hmm. Yes, I could try to split it up by removing the trace hooks and
add them with a later patch.
But the emulation itself would be pretty pointless to split up ...
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
address@hidden +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
- [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation, Hannes Reinecke, 2012/01/13
- Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation, Anthony Liguori, 2012/01/13
- Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation, Andreas Färber, 2012/01/13
- Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation, Avi Kivity, 2012/01/15
- Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation, Anthony Liguori, 2012/01/16
- Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation,
Hannes Reinecke <=
- Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation, Alexander Graf, 2012/01/16
- Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation, Avi Kivity, 2012/01/16
- Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation, Alexander Graf, 2012/01/16
- Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation, Avi Kivity, 2012/01/16
- Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation, Alexander Graf, 2012/01/16
- Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation, Avi Kivity, 2012/01/16