[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback
From: |
Vasilis Liaskovitis |
Subject: |
Re: [Qemu-devel] [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback |
Date: |
Mon, 16 Jan 2012 12:33:45 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jan 13, 2012 at 07:27:01PM -0500, Kevin O'Connor wrote:
> On Fri, Jan 13, 2012 at 12:11:30PM +0100, Vasilis Liaskovitis wrote:
> >
> > Signed-off-by: Vasilis Liaskovitis <address@hidden>
>
> The SeaBIOS change is okay with me, but the qemu/kvm change needs to
> be accepted first.
>
> [...]
> > Method (CPEJ, 2, NotSerialized) {
> > // _EJ0 method - eject callback
> > + Store(ShiftLeft(1, Arg0), PRE)
> > Sleep(200)
> > }
>
> Is the Sleep() still needed?
I believe it's unneccesary. I 'll test without it and resend.
thanks,
- Vasilis
[Qemu-devel] [PATCH 3/3] acpi_piix4: Call KVM_SETSTATE_VCPU ioctl on cpu ejection, Vasilis Liaskovitis, 2012/01/13