Re: [Qemu-devel] [PATCH v2] w32: Build windows and console executables

[Stefan Weil]

Am 13.01.2012 22:31, schrieb Andreas Färber:
> Am 13.01.2012 22:13, schrieb Stefan Weil:
> > Am 22.12.2011 11:20, schrieb Stefan Weil:
> > > System emulation executables with SDL are typically windows
> > > executables. Sometimes console executables are more useful,
> > > so create both variants if linker option -mwindows was detected.
> > >
> > > v2:
> > > This version uses QEMU_PROGW / QEMU_PROG instead of QEMU_PROG /
> > > QEMU_PROGC.
> > >
> > > Signed-off-by: Stefan Weil<address@hidden>
> > > ---
> > > Makefile.target | 16 +++++++++++++++-
> > > 1 files changed, 15 insertions(+), 1 deletions(-)
>
> > Ping? All open questions were solved, so this patch can be committed.
>
> No objection to this patch, just raising the question whether we might
> want to compile code differently for the two targets? For example, does
> -nographic make sense for the *w.exe?
>
> Andreas

Yes, it makes sense.

It's possible to run a *w.exe with stdin/stdout redirected
to a pipe. The msys rxvt terminal works like that and allows
-nographics.

And even without such tricks, the commonly used SDL
implementations redirect stdout to a file, so it is possible
to run a *w.exe with -nographic and use the file (for example
in automated tests which boot a Linux kernel).

So I see no reason to compile both executables differently.

Having executables which are binary compatible has also
advantages for installers (compressing twice the same binary
data should be easy).

Regards,
Stefan