[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/12] Add 'fall through' comments to case statement
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 07/12] Add 'fall through' comments to case statements without break |
Date: |
Fri, 13 Jan 2012 10:51:35 +0000 |
From: Stefan Weil <address@hidden>
These comments are used by static code analysis tools and in code reviews
to avoid false warnings because of missing break statements.
The case statements handled here were reported by coverity.
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/pcnet.c | 1 +
json-lexer.c | 1 +
qemu-option.c | 4 ++++
3 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/pcnet.c b/hw/pcnet.c
index cba253b..306dc6e 100644
--- a/hw/pcnet.c
+++ b/hw/pcnet.c
@@ -1505,6 +1505,7 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t rap,
uint32_t val)
#ifdef PCNET_DEBUG
printf("BCR_SWS=0x%04x\n", val);
#endif
+ /* fall through */
case BCR_LNKST:
case BCR_LED1:
case BCR_LED2:
diff --git a/json-lexer.c b/json-lexer.c
index c21338f..3cd3285 100644
--- a/json-lexer.c
+++ b/json-lexer.c
@@ -301,6 +301,7 @@ static int json_lexer_feed_char(JSONLexer *lexer, char ch,
bool flush)
case JSON_KEYWORD:
case JSON_STRING:
lexer->emit(lexer, lexer->token, new_state, lexer->x, lexer->y);
+ /* fall through */
case JSON_SKIP:
QDECREF(lexer->token);
lexer->token = qstring_new();
diff --git a/qemu-option.c b/qemu-option.c
index 6b23c31..a303f87 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -214,13 +214,17 @@ static int parse_option_size(const char *name, const char
*value, uint64_t *ret)
switch (*postfix) {
case 'T':
sizef *= 1024;
+ /* fall through */
case 'G':
sizef *= 1024;
+ /* fall through */
case 'M':
sizef *= 1024;
+ /* fall through */
case 'K':
case 'k':
sizef *= 1024;
+ /* fall through */
case 'b':
case '\0':
*ret = (uint64_t) sizef;
--
1.7.7.3
- [Qemu-devel] [PATCH 05/12] vnc: fix no-lock-key-sync strncmp() length, (continued)
- [Qemu-devel] [PATCH 05/12] vnc: fix no-lock-key-sync strncmp() length, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 01/12] configure: Modify detection of supported warning options, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 02/12] tcg-arm: fix a typo in comments, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 03/12] Spelling fixes in comments and documentation, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 04/12] vvfat: avoid leaking file descriptor in commit_one_file(), Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 10/12] virtfs-proxy-helper: Clean include files, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 06/12] omap_dss: correct chip[1] index in RFBI_READ/RFBI_STATUS, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 11/12] virtfs-proxy-helper: Add missing printf format attribute, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 09/12] virtfs-proxy-helper: Fix compilation on newer systems, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 12/12] bt-host: add missing break statement, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 07/12] Add 'fall through' comments to case statements without break,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 08/12] hmp: Fix freeing of PciInfoList, Stefan Hajnoczi, 2012/01/13
- Re: [Qemu-devel] [PULL 00/12] Trivial patches for 6 to 13 January 2012, Anthony Liguori, 2012/01/13