[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/7] console: Fix segfault on screendump without VGA
From: |
Alexander Graf |
Subject: |
[Qemu-devel] [PATCH 1/7] console: Fix segfault on screendump without VGA adapter |
Date: |
Thu, 12 Jan 2012 18:35:25 +0100 |
When trying to create a screen dump without having any VGA adapter
inside the guest, QEMU segfaults.
This is because it's trying to switch back to the "previous" screen
it was on before dumping the VGA screen. Unfortunately, in my case
there simply is no previous screen so it accesses a NULL pointer.
Fix it by checking if previous_active_console is actually available.
This is 1.0 material.
Signed-off-by: Alexander Graf <address@hidden>
---
console.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/console.c b/console.c
index f6fe441..ed6a653 100644
--- a/console.c
+++ b/console.c
@@ -186,7 +186,9 @@ void vga_hw_screen_dump(const char *filename)
consoles[0]->hw_screen_dump(consoles[0]->hw, filename);
}
- console_select(previous_active_console->index);
+ if (previous_active_console) {
+ console_select(previous_active_console->index);
+ }
}
void vga_hw_text_update(console_ch_t *chardata)
--
1.6.0.2
- [Qemu-devel] [PULL 1.0 0/7] ppc-stable-1.0 patch queue 2012-01-12, Alexander Graf, 2012/01/12
- [Qemu-devel] [PATCH 7/7] pseries: Don't try to munmap() a malloc()ed TCE table, Alexander Graf, 2012/01/12
- [Qemu-devel] [PATCH 4/7] pseries: Emit device tree nodes in reg order, Alexander Graf, 2012/01/12
- [Qemu-devel] [PATCH 3/7] kvm-ppc: halt secondary cpus when guest reset, Alexander Graf, 2012/01/12
- [Qemu-devel] [PATCH 1/7] console: Fix segfault on screendump without VGA adapter,
Alexander Graf <=
- [Qemu-devel] [PATCH 5/7] pseries: Add a routine to find a stable "default" vty and use it, Alexander Graf, 2012/01/12
- [Qemu-devel] [PATCH 6/7] pseries: Populate "/chosen/linux, stdout-path" in the FDT, Alexander Graf, 2012/01/12
- [Qemu-devel] [PATCH 2/7] pseries: Fix array overrun bug in PCI code, Alexander Graf, 2012/01/12