Re: [Qemu-devel] [PATCH v5 08/11] hw/exynos4210.c: Boot secondary CPU.

[Evgeny Voevodin]

On 01/10/2012 08:16 PM, Peter Maydell wrote:
> On 23 December 2011 11:40, Evgeny Voevodin<address@hidden>  wrote:
> > +    /*
> > +     * Hack: Map SECOND_CPU_BOOTREG, because it is in PMU USER5 register.
> > +     */
> Shouldn't we be modelling the PMU then?
Power Management Unit (PMU) is quite tricky and not critical for emulation.
At this time PMU emulation is paused. It just represents about 16K 
registers array.
I don't think that it is a good idea to include such a device into 
mainline code in
order to provide one of it's register for secondary CPU boot-up.

> > +    memory_region_init_ram(&s->bootreg_mem, NULL, "exynos4210.bootreg", 0x4);
> > +    memory_region_add_subregion(system_mem, EXYNOS4210_SECOND_CPU_BOOTREG,
> > +&s->bootreg_mem);
> > +
>
> > +static int exynos4_board_smp_bootreg_addr[EXYNOS4_NUM_OF_BOARDS] = {
> > +    [EXYNOS4_BOARD_NURI]     = EXYNOS4210_SECOND_CPU_BOOTREG,
> > +    [EXYNOS4_BOARD_SMDKC210] = EXYNOS4210_SECOND_CPU_BOOTREG,
> > +};
> Is this actually likely to differ between boards, or is it really a property
> of the SoC itself?
Yes, it is specific to a board. There are different boards on exynos4210 
SOC which have
different bootreg addresses. At this time we don't emulate them.

--
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: address@hidden