Re: [Qemu-devel] [PATCH 03/11] check-qdict: convert to gtest

[Anthony Liguori]

On 01/09/2012 01:26 PM, Andreas Färber wrote:
> Am 09.01.2012 16:56, schrieb Anthony Liguori:
> > Signed-off-by: Anthony Liguori<address@hidden>
> > ---
> >   Makefile       |    6 --
> >   check-qdict.c  |  246 +++++++++++++++++++++++++-------------------------------
> >   configure      |    4 +-
> >   tests/Makefile |    6 ++
> >   4 files changed, 119 insertions(+), 143 deletions(-)
>
> > diff --git a/Makefile b/Makefile
> > index 80fb512..4823144 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -294,12 +294,6 @@ endif
> >   test speed: all
> >         $(MAKE) -C tests/tcg $@
> >
> > -.PHONY: check
> > -check: $(patsubst %,run-check-%,$(CHECKS))
> > -
> > -run-check-%: %
> > -       ./$<
> > -
> >   .PHONY: TAGS
> >   TAGS:
> >         find "$(SRC_PATH)" -name '*.[hc]' -print0 | xargs -0 etags
>
> > diff --git a/tests/Makefile b/tests/Makefile
> > index c11d980..cff9ff3 100644
> > --- a/tests/Makefile
> > +++ b/tests/Makefile
> > @@ -29,3 +29,9 @@ test-qmp-input-visitor: test-qmp-input-visitor.o 
> > $(qobject-obj-y) $(qapi-obj-y)
> >   test-qmp-commands.o: $(addprefix $(qapi-dir)/, test-qapi-types.c 
> > test-qapi-types.h test-qapi-visit.c test-qapi-visit.h test-qmp-marshal.c 
> > test-qmp-commands.h) $(qapi-obj-y)
> >   test-qmp-commands: test-qmp-commands.o $(qobject-obj-y) $(qapi-obj-y) 
> > $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test-qapi-types.o 
> > $(qapi-dir)/test-qmp-marshal.o module.o
> >
> > +.PHONY: check
> > +check: $(patsubst %,run-check-%,$(CHECKS))
> > +
> > +run-check-%: %
> > +       ./$<
> > +
>
> These should be squashed into 02/11. Unrelated to check-qdict.

Thanks.

Regards,

Anthony Liguori

> Andreas