Re: [Qemu-devel] [PATCH qemu-kvm] Fix: SCI isn't sent on cpu hotplug

[Gleb Natapov]

On Mon, Jan 09, 2012 at 11:03:10AM +0100, Jan Kiszka wrote:
> On 2012-01-09 09:47, Gleb Natapov wrote:
> > On Sun, Jan 08, 2012 at 10:40:04PM +0100, Igor Mammedov wrote:
> >>  Change introduced by e71f08bb4a
> >>     "Fix cpu/pci hotplug to generate level triggered interrupt."
> >>  was lost somewhre along the way. And as result SCI is not sent in
> >>  case of cpu hotplug event.
> >>  Restoring hunk 1 of e71f08bb4a fixes issue.
> >>
> > Hmm, I sent similar patch [1] last time someone complained about cpu hotplug
> > here. Which remind me that in that thread more problem were found in cpu
> > hotplug. IIRC Jan collected all the patches. Jan, what happened to
> > them?
> 
> My patches should have been superseded by the work of Ping Fan on the
> ICC bus.
> 
Didn't they fix some problems with bringing new cpu online, not just
making cpu hotplugable in qdev? May be I misremember. BTW do you know
what happened with ICC bus patches?

> Jan
> 
> > 
> > [1] http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/76399
> > 
> >> Signed-off-by: Igor Mammedov <address@hidden>
> >> ---
> >>  hw/acpi_piix4.c |    3 ++-
> >>  1 files changed, 2 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
> >> index 1b35707..741a8cc 100644
> >> --- a/hw/acpi_piix4.c
> >> +++ b/hw/acpi_piix4.c
> >> @@ -94,7 +94,8 @@ static void pm_update_sci(PIIX4PMState *s)
> >>                     ACPI_BITMASK_POWER_BUTTON_ENABLE |
> >>                     ACPI_BITMASK_GLOBAL_LOCK_ENABLE |
> >>                     ACPI_BITMASK_TIMER_ENABLE)) != 0) ||
> >> -        (((s->gpe.sts[0] & s->gpe.en[0]) & PIIX4_PCI_HOTPLUG_STATUS) != 
> >> 0);
> >> +        (((s->gpe.sts[0] & s->gpe.en[0]) &
> >> +          (PIIX4_CPU_HOTPLUG_STATUS | PIIX4_PCI_HOTPLUG_STATUS)) != 0);
> >>  
> >>      qemu_set_irq(s->irq, sci_level);
> >>      /* schedule a timer interruption if needed */
> >> -- 
> >> 1.7.7.5
> > 
> > --
> >                     Gleb.
> 
> -- 
> Siemens AG, Corporate Technology, CT T DE IT 1
> Corporate Competence Center Embedded Linux

--
                        Gleb.