qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] stop the periodic RTC update timer


From: Jan Kiszka
Subject: Re: [Qemu-devel] [PATCH 3/3] stop the periodic RTC update timer
Date: Fri, 06 Jan 2012 15:26:37 -0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

On 2012-01-06 05:37, Zhang, Yang Z wrote:
> change the RTC update logic to use host time with offset to calculate RTC 
> clock.
>       There have no need to use two periodic timers to maintain an internal 
> timer for RTC clock update and alarm check. Instead, we calculate the real 
> RTC time by the host time with an offset. For alarm and updated-end 
> interrupt, if guest enabled it, then we setup a timer, or else, stop it.
> 
> Signed-off-by: Yang Zhang <address@hidden>

I appreciate this effort!

However, not having looked at details yet, two things jumped at me:
 - You cannot simply change the vmstate format without caring about
   migration from older qemu versions. Ideally, if possible the existing
   format is kept and translated to new internal representations on
   save/load.
 - Please respect the coding style. It's documented, and we also have a
   checker.

Thanks,
Jab


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]