[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/9] ahci: add support for non-PCI based control
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 6/9] ahci: add support for non-PCI based controllers |
Date: |
Sat, 24 Dec 2011 00:39:17 +0000 |
On 22 December 2011 18:20, Mark Langsdorf <address@hidden> wrote:
> From: Rob Herring <address@hidden>
>
> Add support for ahci on sysbus.
Again, IDE isn't my domain, but some minor points:
> +typedef struct PlatAHCIState {
> + SysBusDevice busdev;
> + AHCIState ahci;
> +} PlatAHCIState;
Indentation is wrong here.
> +static SysBusDeviceInfo plat_ahci_info[] = {
> + {
> + .qdev.name = "plat-ahci",
> + .qdev.size = sizeof(PlatAHCIState),
> + .init = plat_ahci_init,
> + },{
> + /* end of list */
> + }
> +};
> +
> +static void plat_ahci_register(void)
> +{
> + sysbus_register_withprop(plat_ahci_info);
> +}
sysbus_register_withprop() takes a single SysBusDeviceInfo,
not a list.
-- PMM
- [Qemu-devel] [PATCH 5/9] ahci: convert ahci_reset to use AHCIState, (continued)
- [Qemu-devel] [PATCH 5/9] ahci: convert ahci_reset to use AHCIState, Mark Langsdorf, 2011/12/22
- [Qemu-devel] [PATCH v2 1/9] arm: add missing scu registers, Mark Langsdorf, 2011/12/22
- [Qemu-devel] [PATCH 9/9] arm: increase a9mp interrupts to 160, Mark Langsdorf, 2011/12/22
- [Qemu-devel] [PATCH v2 3/9] arm: add dummy v7 cp15 config_base_register, Mark Langsdorf, 2011/12/22
- [Qemu-devel] [PATCH v2 8/9] Add xgmac ethernet model, Mark Langsdorf, 2011/12/22
- [Qemu-devel] [PATCH 6/9] ahci: add support for non-PCI based controllers, Mark Langsdorf, 2011/12/22
- Re: [Qemu-devel] [PATCH 6/9] ahci: add support for non-PCI based controllers,
Peter Maydell <=
- [Qemu-devel] [PATCH v2 7/9] add L2x0/PL310 cache controller device, Mark Langsdorf, 2011/12/22