[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and compositio
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree |
Date: |
Fri, 16 Dec 2011 11:36:43 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
Am 16.12.2011 11:17, schrieb Paolo Bonzini:
> On 12/16/2011 10:42 AM, Kevin Wolf wrote:
>>>>
>>>> Applied.
>>>>
>>>> Regards,
>>>>
>>>> Anthony Liguori
>> So you pushed this with qdev_property_add_child() calls spread all over
>> the place instead of being treated like other properties?:-(
>
> I think actually this is not the biggest problem. child properties are
> dynamic, and it's not a problem IMO if they are created like that.
That they are added in an init function is an indicator that they aren't
really dynamic. Some of them are conditional, some aren't. For those
which are, I think having a child property that can be NULL could be
reasonable. In the end you want to have this kind of things configurable
via QOM instead of hard-coded in the devices, right?
> I don't like that _link_ properties are spread all over the place
> instead of being treated like other properties. Link properties are
> static, and PROP_PTR properties could often be converted to links.
Yes, links too.
Kevin
- [Qemu-devel] [PATCH v3 14/20] rtc: make piix3 set the rtc as a child (v2), (continued)
- [Qemu-devel] [PATCH v3 14/20] rtc: make piix3 set the rtc as a child (v2), Anthony Liguori, 2011/12/12
- [Qemu-devel] [PATCH v3 16/20] qom: optimize qdev_get_canonical_path using a parent link, Anthony Liguori, 2011/12/12
- [Qemu-devel] [PATCH v3 19/20] qdev: add a qdev_get_type() function and expose as a 'type' property, Anthony Liguori, 2011/12/12
- [Qemu-devel] [PATCH v3 13/20] dev: add an anonymous peripheral container, Anthony Liguori, 2011/12/12
- [Qemu-devel] [PATCH v3 17/20] qom: add vga node to the pc composition tree, Anthony Liguori, 2011/12/12
- [Qemu-devel] [PATCH v3 15/20] rtc: add a dynamic property for retrieving the date, Anthony Liguori, 2011/12/12
- [Qemu-devel] [PATCH v3 18/20] qom: add string property type, Anthony Liguori, 2011/12/12
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree, Anthony Liguori, 2011/12/15
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree, Kevin Wolf, 2011/12/16
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree, Paolo Bonzini, 2011/12/16
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree, Paolo Bonzini, 2011/12/16
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree, Kevin Wolf, 2011/12/16
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree, Paolo Bonzini, 2011/12/16
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree, Anthony Liguori, 2011/12/16
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree, Anthony Liguori, 2011/12/16
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree, Paolo Bonzini, 2011/12/16
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree, Anthony Liguori, 2011/12/16
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree, Kevin Wolf, 2011/12/16
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree, Anthony Liguori, 2011/12/16
- Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree, Paolo Bonzini, 2011/12/16