Re: [Qemu-devel] [PATCH] usb-ohci: return USBBus in usb_ohci_init_pci

[Anthony Liguori]

On 12/15/2011 02:17 AM, Stefan Hajnoczi wrote:
> On Wed, Dec 14, 2011 at 06:10:17PM -0600, Anthony Liguori wrote:
> > Untested, but seemingly obvious and hard to screw up..
>
> Sounds like a challenge so let's take a look...
>
> > -void usb_ohci_init_pci(struct PCIBus *bus, int devfn)
> > +USBBus *usb_ohci_init_pci(struct PCIBus *bus, int devfn)
> >   {
> > -    pci_create_simple(bus, devfn, "pci-ohci");
> > +    PCIDevice *dev = pci_create_simple(bus, devfn, "pci-ohci");
> > +    OHCIPCIState *ohci = DO_UPCAST(OHCIPCIState, pci_dev, dev);
> > +
> > +    return&ohci->state.bus
>
> Missing semicolon.

Heh, awesome :-)  Okay, I'll actually test it next time.

Regards,

Anthony Liguori

> Stefan