Re: [Qemu-devel] [PATCH v4 00/15] uq/master: Introduce basic irqchip support

[Jan Kiszka]

On 2011-12-08 22:25, Blue Swirl wrote:
> On Thu, Dec 8, 2011 at 11:52, Jan Kiszka <address@hidden> wrote:
>> Changes in v4:
>> - rebased of current uq/master
>> - fixed stupid bugs that broke bisectability and user space irqchip mode
>> - integrated NMI-over-LINT1 injection logic
> 
> I had comments to one patch, others look fine.
> 
> Overall, string based subtype selection does not somehow seem to be a
> hot idea, but this could be used as a starting point which should be
> cleaned up later when we have proper device composition. APIC and x86
> interrupt handling need more cleanup anyway.

Yes, more than likely. However, I think the string-based selection is
the best that can be done right now. It gives us, e.g., pretty-printing
of the backend property so that you can easily check what mode is in use.

The next area of ugliness will be the PIT and its relation to the HPET.
I started looking into this, found some bugs, but do not really have a
nice model for all that yet.

Looking into the remaining remarks now.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux