Re: [Qemu-devel] [PATCH 12/14] SD card: add query function to check wether SD card currently ready to recieve data Before executing data transfer to card, we must check that previously issued command wasn't a simple query command (for ex. CMD13), whi

[Peter Maydell]

On 7 December 2011 09:47, Evgeny Voevodin <address@hidden> wrote:
> From: Mitsyanko Igor <address@hidden>

Shouldn't we have a Signed-off-by: from this person as well?

There's a missing blank line in the commit message which
has put all of it into the Subject.

> Signed-off-by: Evgeny Voevodin <address@hidden>
> ---
>  hw/sd.c |    5 +++++
>  hw/sd.h |    1 +
>  2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/hw/sd.c b/hw/sd.c
> index 10e26ad..ddb9d39 100644
> --- a/hw/sd.c
> +++ b/hw/sd.c
> @@ -1670,3 +1670,8 @@ void sd_enable(SDState *sd, int enable)
>  {
>     sd->enable = enable;
>  }
> +
> +int sd_recieve_ready(SDState *sd)
> +{
> +    return sd->state == sd_receivingdata_state;
> +}

"receive" is spelt "ei", not "ie" -- please fix the function
name.

-- PMM