Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

[Avi Kivity]

On 10/17/2011 06:00 PM, Lai Jiangshan wrote:
> From: Lai Jiangshan <address@hidden>
>
> Currently, NMI interrupt is blindly sent to all the vCPUs when NMI
> button event happens. This doesn't properly emulate real hardware on
> which NMI button event triggers LINT1. Because of this, NMI is sent to
> the processor even when LINT1 is maskied in LVT. For example, this
> causes the problem that kdump initiated by NMI sometimes doesn't work
> on KVM, because kdump assumes NMI is masked on CPUs other than CPU0.
>
> With this patch, inject-nmi request is handled as follows.
>
> - When in-kernel irqchip is disabled, deliver LINT1 instead of NMI
>   interrupt.
> - When in-kernel irqchip is enabled, get the in-kernel LAPIC states
>   and test the APIC_LVT_MASKED, if LINT1 is unmasked, and then
>   delivering the NMI directly. (Suggested by Jan Kiszka)
>
> Changed from old version:
>   re-implement it by the Jan's suggestion.
>   fix the race found by Jan.

This patch fell through the cracks, sorry.  Now applied.

Sasha, this patch highlights the issues with KVM_NMI.

-- 
error compiling committee.c: too many arguments to function