Re: [Qemu-devel] [PATCH] Add minimal Vexpress Cortex A15 support

[Andreas Färber]

Am 01.12.2011 02:37, schrieb address@hidden:
> From: Bill Carson <address@hidden>
> 
> This patch adds minimal codes to support A15  which enables ARM KVM could
> run Guest OS build with Versatile Express Cortex-A15x4 tile.
> 
> Signed-off-by: Bill Carson <address@hidden>
> ---

> diff --git a/hw/a15mpcore.c b/hw/a15mpcore.c
> new file mode 100644
> index 0000000..2518c17
> --- /dev/null
> +++ b/hw/a15mpcore.c
> @@ -0,0 +1,118 @@
> +/*
> + * ARM A15MPCore internal peripheral emulation (common code).

ARM Cortex-A15 MPCore, please. No need to repeat the short file name.

> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index e712554..6a2c89d 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -217,6 +217,36 @@ static void cpu_reset_model_id(CPUARMState *env, 
> uint32_t id)
>          env->cp15.c0_ccsid[1] = 0x200fe015; /* 16k L1 icache. */
>          env->cp15.c1_sys = 0x00c50078;
>          break;
> +    case ARM_CPUID_CORTEXA15: /* most same as A9 */
> +        set_feature(env, ARM_FEATURE_V4T);
> +        set_feature(env, ARM_FEATURE_V5);
> +        set_feature(env, ARM_FEATURE_V6);
> +        set_feature(env, ARM_FEATURE_V6K);
> +        set_feature(env, ARM_FEATURE_V7);
> +        set_feature(env, ARM_FEATURE_AUXCR);
> +        set_feature(env, ARM_FEATURE_THUMB2);
> +        set_feature(env, ARM_FEATURE_VFP);
> +        set_feature(env, ARM_FEATURE_VFP3);
> +        set_feature(env, ARM_FEATURE_VFP_FP16);
> +        set_feature(env, ARM_FEATURE_NEON);
> +        set_feature(env, ARM_FEATURE_THUMB2EE);
> +        /* Note that A9 supports the MP extensions even for
> +         * A9UP and single-core A9MP (which are both different
> +         * and valid configurations; we don't model A9UP).
> +         */
> +        set_feature(env, ARM_FEATURE_V7MP);

Peter, this calls for my feature inference series.

Now that 1.0 is out I'll have another go at it later tonight, adding
your suggested rules. Feel free to pick up the initial ones if you like.

Andreas