[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.0] malta: Fix regression (i8259 interrupts did
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH 1.0] malta: Fix regression (i8259 interrupts did not work) |
Date: |
Sun, 27 Nov 2011 10:35:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
On 11/25/2011 09:01 AM, Stefan Weil wrote:
>
> Boards normally have state structures, the device model
> supports this and is not wrong here.
>
> The Malta implementation simply needs conversion to qdev.
> This is something which will be done after QEMU 1.0.
>
> My patch is not the final solution. It's simply a hack to get
> a working Malta in QEMU 1.0. If the qdev solution is preferred
> for 1.0, I can also send a Malta qdev patch.
>
For 1.0, the simpler patch is better IMO (though I prefer g_new()
instead of static; g_new() is reentrant and catches the eye, while
static will hide from sight).
--
error compiling committee.c: too many arguments to function