Re: [Qemu-devel] [PATCH 1.0] checkpatch.pl: fix CAST detection

[Blue Swirl]

Thanks, applied.

On Fri, Nov 25, 2011 at 09:24, Paolo Bonzini <address@hidden> wrote:
> From: Florian Mickler <address@hidden>
>
> We should only claim that something is a cast if we did not encouter a
> token before, that did set av_pending.
>
> This fixes the operator * in the line below to be detected as binary (vs
> unary).
>
> kmalloc(sizeof(struct alphatrack_ocmd) * true_size, GFP_KERNEL);
>
> Reported-by: Peter Chubb <nicta.com.au>
> Signed-off-by: Florian Mickler <address@hidden>
> (cherry-picked from Linux kernel commit 
> c023e4734c3e8801e0ecb5e81b831d42a374d861)
> Signed-off-by: Paolo Bonzini <address@hidden>
> Cc: Blue Swirl <address@hidden>
> ---
>  scripts/checkpatch.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 36d6851..ddd27d8 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -859,7 +859,7 @@ sub annotate_values {
>                                $av_preprocessor = 0;
>                        }
>
> -               } elsif ($cur =~ /^(\(\s*$Type\s*)\)/) {
> +               } elsif ($cur =~ /^(\(\s*$Type\s*)\)/ && $av_pending eq '_') {
>                        print "CAST($1)\n" if ($dbg_values > 1);
>                        push(@av_paren_type, $type);
>                        $type = 'C';
> --
> 1.7.7.1
>
>