Re: [Qemu-devel] [PATCH v3 07/11] bonito: convert north bridge register mapping to memory API

[Peter Maydell]

2011/11/22 Benoît Canet <address@hidden>:
>  static int bonito_initfn(PCIDevice *dev)
>  {
>     PCIBonitoState *s = DO_UPCAST(PCIBonitoState, dev, dev);
> +    SysBusDevice *sysbus = sysbus_from_qdev(&dev->qdev);

This looks odd. The device here is a PCIBonitoState, which
is-a PCIDevice, which is-a DeviceState. It's not a SysBusDevice
and merely casting doesn't make it one.

I'm not sure what should be being done here, but I'm pretty
sure this won't work...

-- PMM