[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/usb-net.c: Fix precedence bug when checking
|
From: |
andrzej zaborowski |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw/usb-net.c: Fix precedence bug when checking rndis_state |
|
Date: |
Mon, 14 Nov 2011 04:00:03 +0100 |
On 9 November 2011 22:09, Peter Maydell <address@hidden> wrote:
> "!X == 2" is always false (spotted by Coverity), so the checks
> for whether rndis is in the correct state would never fire.
I pushed this patch because it's a bugfix and the check is guarded by
is_rndis() so there should be no risk of affecting non-rndis.
Cheers