[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git rep
From: |
Ingo Molnar |
Subject: |
Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/ |
Date: |
Wed, 9 Nov 2011 09:51:20 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* Gerd Hoffmann <address@hidden> wrote:
> > For reference, the default set of colors now is (from
> > tools/perf/util/ui/browser.c):
> >
> > static struct ui_browser__colorset {
> > const char *name, *fg, *bg;
> > int colorset;
> > } ui_browser__colorsets[] = {
> > {
> > .colorset = HE_COLORSET_TOP,
> > .name = "top",
> > .fg = "red",
> > .bg = "default",
>
> Bad idea IMO. Setting only one of foreground+background gives
> pretty much unpredictable results. My xterms have different
> background colors, the ones with a root shell happen to have a
> (dark) red background. Which results in red-on-dark-red text. Not
> good.
>
> I'd strongly suggest to either set both background and foreground
> to default or to set both to a specific color. When doing the
> latter make sure the colors have enougth contrast so they are
> readable.
Indeed.
What we want to have is to have a set of distinctive colors - just
two (background, foreground) colors are not enough - we also need
colors to highlight certain information - we need 5-6 colors for the
output to be maximally expressive. Is there a canonical way to handle
that while still adapting to user preferences automatically by taking
background/foreground color scheme of the xterm into account?
I suspect to fix the worst of the fallout we could add some logic to
detect low contrast combinations (too low color distance) and fall
back to the foreground/background colors in that case.
Plus allowing full .perfconfig configurability of all the relevant
colors, for those with special taste.
Thanks,
Ingo
- Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels, (continued)
- Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels, Anthony Liguori, 2011/11/07
- Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels, Theodore Tso, 2011/11/07
- [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Ingo Molnar, 2011/11/08
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Theodore Tso, 2011/11/08
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Arnaldo Carvalho de Melo, 2011/11/08
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Gerd Hoffmann, 2011/11/08
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Arnaldo Carvalho de Melo, 2011/11/08
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Gerd Hoffmann, 2011/11/08
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Arnaldo Carvalho de Melo, 2011/11/08
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Ingo Molnar, 2011/11/09
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/,
Ingo Molnar <=
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Gerd Hoffmann, 2011/11/09
- Re: [Qemu-devel] [F.A.Q.] the advantages of a sha red tool/kernel Git repository, tools/perf/ and tool s/kvm/, Hagen Paul Pfeifer, 2011/11/09
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Arnaldo Carvalho de Melo, 2011/11/09
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Gerd Hoffmann, 2011/11/09
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Arnaldo Carvalho de Melo, 2011/11/09
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Arnaldo Carvalho de Melo, 2011/11/09
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Peter Zijlstra, 2011/11/09
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Arnaldo Carvalho de Melo, 2011/11/09
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Ingo Molnar, 2011/11/09
- Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/, Jim Paris, 2011/11/09