Re: [Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id

[Gerd Hoffmann]

On 11/07/11 17:00, Anthony Liguori wrote:
> On 11/07/2011 09:33 AM, Gerd Hoffmann wrote:
>> This patch removes the code lines which set the subsystem id for the
>> emulated ac97 card to 8086:0000.  Due to the device id being zero the
>> subsystem id isn't vaild anyway.  With the patch applied the sound card
>> gets the default qemu subsystem id (1af4:1100) instead.
> 
> I don't like having a property of "use broken".

Well, it *is* broken.
Suggestions for a better name?

> Wouldn't it be better to have the subsystem vendor and device id be
> configurable, set the default to the qemu subsystem ids, and then set it
> to 8086:0000 for < 1.0?

I don't want this being fully configurable just for the snake of
backward compatibility with old qemu versions.

cheers,
  Gerd