Re: [Qemu-devel] Wierd hack to sound/pci/intel8x0.c

[Takashi Iwai]

At Mon, 07 Nov 2011 11:35:49 +0100,
Gerd Hoffmann wrote:
> 
>   Hi,
> 
> > We discuss Intel ICH/AC'97 (snd-intel8x0) here, but I hope that PCI SSID
> > is same.
> 
> Hmm, it's not, the ac97 emulation doesn't use the default qemu subsystem
> id for some reason.  Here is the entry:
> 
> address@hidden ~]# lspci -vns6
> 00:06.0 0401: 8086:2415 (rev 01)
>         Subsystem: 8086:0000
>         Physical Slot: 6
>         Flags: bus master, medium devsel, latency 0, IRQ 10
>         I/O ports at c000 [size=1K]
>         I/O ports at c400 [size=256]
>         Kernel driver in use: Intel ICH
>         Kernel modules: snd-intel8x0
> 
> I guess that should be fixed.  8086:0000 isn't valid anyway and I doubt
> it serves any useful purpose other than avoiding a guest complaining
> about the subsystem id being unset.

Yeah, especially the value 0 looks pretty bad.

> /me goes preparing a patch.

Thanks!


Takashi