|
From: | Stefan Weil |
Subject: | Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer |
Date: | Mon, 31 Oct 2011 18:13:52 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110921 Thunderbird/3.1.15 |
Am 31.10.2011 11:05, schrieb Paolo Bonzini:
On 10/31/2011 08:23 AM, TeLeMan wrote:"mmtimer" and "win32" alarms have no rearm. Should we remove these two alarms?> static void qemu_rearm_alarm_timer(struct qemu_alarm_timer *t) > { > - if (!alarm_has_dynticks(t)) > + int64_t nearest_delta_ns; > + assert(alarm_has_dynticks(t));Yes. I think with iothread they are broken, or almost broken. Paolo
They can't be more broken: I noticed today that QEMU on W32 aborts with the default timer (mmtimer) very quickly. Stefan
[Prev in Thread] | Current Thread | [Next in Thread] |