Re: [Qemu-devel] [PATCH 13/25] vmstate: port ppc cpu

[Alexander Graf]

On 25.10.2011, at 16:00, Juan Quintela wrote:

> Added sdr1_vmstate because storing the value requires calling 
> ppc_store_sdr1().
> The position when the function is called also changes (I think it is save).

Thanks for converting this. I'm fairly sure that vmsave is broken atm anyways 
and that someone will have to go through all the fields and make sure they're 
still working properly. However you're definitely not making the situation 
worse, so here's only a small comment:

> 
> Signed-off-by: Juan Quintela <address@hidden>
> CC: Alexander Graf <address@hidden>
> ---
> target-ppc/cpu.h     |    4 +-
> target-ppc/machine.c |  245 ++++++++++++++++++--------------------------------
> 2 files changed, 89 insertions(+), 160 deletions(-)
> 
> +        VMSTATE_UINTTL_ARRAY(spr, CPUState, 1024),

Shouldn't sizeof(((CPUState*)NULL)->spr / sizeof(target_ulong)) work as size 
field?

Alex