[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] target-arm: Add ARM UDIV/SDIV support
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] target-arm: Add ARM UDIV/SDIV support |
Date: |
Sun, 23 Oct 2011 02:20:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 |
Am 20.10.2011 15:16, schrieb Peter Maydell:
> Add support for UDIV and SDIV in ARM mode. This is a new optional
> feature for A profile cores (Thumb mode has had UDIV and SDIV for
> M profile cores for some time).
>
> Signed-off-by: Peter Maydell <address@hidden>
Lightly ...
Tested-by: Andreas Färber <address@hidden>
Andreas
> ---
> target-arm/cpu.h | 1 +
> target-arm/helper.c | 5 ++++-
> target-arm/translate.c | 19 +++++++++++++++++++
> 3 files changed, 24 insertions(+), 1 deletions(-)
>
> diff --git a/target-arm/cpu.h b/target-arm/cpu.h
> index 00e012e..af3904d 100644
> --- a/target-arm/cpu.h
> +++ b/target-arm/cpu.h
> @@ -375,6 +375,7 @@ enum arm_features {
> ARM_FEATURE_V5,
> ARM_FEATURE_STRONGARM,
> ARM_FEATURE_VAPA, /* cp15 VA to PA lookups */
> + ARM_FEATURE_ARM_DIV, /* divide supported in ARM encoding */
> };
>
> static inline int arm_feature(CPUARMState *env, int feature)
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index faf0283..3a51fd7 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -207,7 +207,7 @@ static void cpu_reset_model_id(CPUARMState *env, uint32_t
> id)
> set_feature(env, ARM_FEATURE_VFP_FP16);
> set_feature(env, ARM_FEATURE_NEON);
> set_feature(env, ARM_FEATURE_THUMB2EE);
> - set_feature(env, ARM_FEATURE_THUMB_DIV);
> + set_feature(env, ARM_FEATURE_ARM_DIV);
> set_feature(env, ARM_FEATURE_V7MP);
> break;
> case ARM_CPUID_TI915T:
> @@ -261,6 +261,9 @@ static void cpu_reset_model_id(CPUARMState *env, uint32_t
> id)
> if (arm_feature(env, ARM_FEATURE_V7)) {
> set_feature(env, ARM_FEATURE_VAPA);
> }
> + if (arm_feature(env, ARM_FEATURE_ARM_DIV)) {
> + set_feature(env, ARM_FEATURE_THUMB_DIV);
> + }
> }
>
> void cpu_reset(CPUARMState *env)
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index deb0bcf..812a9e7 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -7639,6 +7639,25 @@ static void disas_arm_insn(CPUState * env,
> DisasContext *s)
> store_reg(s, rn, tmp);
> }
> break;
> + case 1:
> + case 3:
> + /* SDIV, UDIV */
> + if (!arm_feature(env, ARM_FEATURE_ARM_DIV)) {
> + goto illegal_op;
> + }
> + if (((insn >> 5) & 7) || (rd != 15)) {
> + goto illegal_op;
> + }
> + tmp = load_reg(s, rm);
> + tmp2 = load_reg(s, rs);
> + if (insn & (1 << 21)) {
> + gen_helper_udiv(tmp, tmp, tmp2);
> + } else {
> + gen_helper_sdiv(tmp, tmp, tmp2);
> + }
> + tcg_temp_free_i32(tmp2);
> + store_reg(s, rn, tmp);
> + break;
> default:
> goto illegal_op;
> }
- [Qemu-devel] [PULL 0/7] target-arm queue, Peter Maydell, 2011/10/20
- [Qemu-devel] [PATCH 3/7] target-arm: Rename ARM_FEATURE_DIV to _THUMB_DIV, Peter Maydell, 2011/10/20
- [Qemu-devel] [PATCH 7/7] target-arm/machine.c: Restore VFP registers correctly, Peter Maydell, 2011/10/20
- [Qemu-devel] [PATCH 5/7] softfloat: Implement fused multiply-add, Peter Maydell, 2011/10/20
- [Qemu-devel] [PATCH 2/7] target-arm: v6 media multiply space: UNDEF on unassigned encodings, Peter Maydell, 2011/10/20
- [Qemu-devel] [PATCH 4/7] target-arm: Add ARM UDIV/SDIV support, Peter Maydell, 2011/10/20
- Re: [Qemu-devel] [PATCH 4/7] target-arm: Add ARM UDIV/SDIV support,
Andreas Färber <=
- [Qemu-devel] [PATCH 6/7] target-arm: Implement VFPv4 fused multiply-accumulate insns, Peter Maydell, 2011/10/20
- [Qemu-devel] [PATCH 1/7] rsqrte_f32: No need to copy sign bit., Peter Maydell, 2011/10/20