qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-arm: Tidy up ARM1136 CPUID naming


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] target-arm: Tidy up ARM1136 CPUID naming
Date: Sat, 22 Oct 2011 11:20:34 +0100

On 3 October 2011 11:32, Andreas Färber <address@hidden> wrote:
> -#define ARM_CPUID_ARM1136     0x4117b363
> -#define ARM_CPUID_ARM1136_R2  0x4107b362
> +#define ARM_CPUID_ARM1136_R1P3 0x4117b363
> +#define ARM_CPUID_ARM1136_R0P2 0x4107b362

I don't think the patchlevels are important enough to
memorialise in the constant names. The important
distinction in behaviour is between the r0 and r1, so
I think that ARM1136_R0 vs _R1 would be better.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]