Re: [Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough.

[Anthony PERARD]

On Wed, Oct 19, 2011 at 15:48, Peter Maydell <address@hidden> wrote:
> On 19 October 2011 14:56, Anthony PERARD <address@hidden> wrote:
>> +if test "$xen_pci_passthrough" != "no"; then
>> +  if test "$xen" = "yes" -a "$linux" = "yes"; then
>> +    xen_pci_passthrough=yes
>> +  else
>> +    if test "$xen_pci_passthrough" = "yes"; then
>> +      feature_not_found "Xen PCI Passthrough without Xen or not on linux"
>> +    fi
>> +    xen_pci_passthrough=no
>> +  fi
>> +fi
>
> The -a flag to test is obsolete -- don't use it in new code.

ok, I'll just replace it by "&& test"

> This is a bit of a misuse of the feature_not_found function IMHO.
> (Also, Linux needs a capital letter.)

Yes, probably this message will be more useful:
echo "ERROR: User requested feature Xen PCI Passthrough"
echo "ERROR: but this feature require /sys from Linux"

Thanks,

-- 
Anthony PERARD