[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/21] target-sparc: Pass float64 parameters ins
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 04/21] target-sparc: Pass float64 parameters instead of dt0/1 temporaries. |
Date: |
Tue, 18 Oct 2011 13:07:54 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 |
On 10/18/2011 01:04 PM, Blue Swirl wrote:
>> > - F_HELPER(name, d) \
>> > + float64 helper_f ## name ## d (CPUState * env, float64 src1,\
>> > + float64 src2) \
>> > { \
>> > - DT0 = float64_ ## name (DT0, DT1, &env->fp_status); \
>> > + return float64_ ## name (src1, src2, &env->fp_status); \
>> > } \
> Could we call float64_##name() directly from generated code and avoid
> the wrapper? Translator could generate &env->fp_status and in other
> cases that could be passed around instead of env.
>
The helper.h machinery isn't set up for that. Also, see patch 11.
r~
- [Qemu-devel] [PATCH 00/21] Sparc FPU/VIS improvements, Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 05/21] target-sparc: Make VIS helpers const when possible., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 04/21] target-sparc: Pass float64 parameters instead of dt0/1 temporaries., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 11/21] target-sparc: Do exceptions management fully inside the helpers., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 13/21] target-sparc: Implement PDIST., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 12/21] sparc-linux-user: Handle SIGILL., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 15/21] target-sparc: Implement EDGE* instructions., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 09/21] target-sparc: Change fpr representation to doubles., Richard Henderson, 2011/10/18
- [Qemu-devel] [PATCH 14/21] target-sparc: Implement fpack{16, 32, fix}., Richard Henderson, 2011/10/18