Re: [Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support

[Kevin Wolf]

Am 14.10.2011 10:41, schrieb Paolo Bonzini:
> This similarly adds support for coroutine and asynchronous discard.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>

Do we really need bdrv_discard and bdrv_aio_discard in the backends? I
think it makes sense to have a bdrv_aio_discard() in block.h as AIO
generally fits well for device models, but I would just require
bdrv_co_discard for any block drivers implementing discard.

>       I was not sure if qcow2 could be changed to co_discard, though
>       I suspected yes.

As discussed on IRC: Yes, it just must make sure to take s->lock.

Kevin