Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

[Kevin Wolf]

Am 14.10.2011 10:41, schrieb Paolo Bonzini:
> Add coroutine support for flush and apply the same emulation that
> we already do for read/write.  bdrv_aio_flush is simplified to always
> go through a coroutine.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>

To make the implementation more consistent with read/write operations,
wouldn't it make sense to provide a bdrv_co_flush() globally instead of
using the synchronous version as the preferred public interface?

This is the semantics that I would expect of a bdrv_co_flush() anyway,
your use of it for an AIO emulation functions confused me a bit at first.

Kevin