[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-aio: Allow reads beyond the end of growab
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] linux-aio: Allow reads beyond the end of growable images |
Date: |
Thu, 13 Oct 2011 15:55:08 +0100 |
On Thu, Oct 13, 2011 at 2:49 PM, Kevin Wolf <address@hidden> wrote:
> This is the linux-aio version of commits 22afa7b5 (raw-posix, synchronous) and
> ba1d1afd (posix-aio-compat). Reads now produce zeros after the end of file
> instead of failing or resulting in short reads, making linux-aio compatible
> with the behaviour of synchronous raw-posix requests and posix-aio-compat.
>
> The problem can be reproduced like this:
>
> dd if=/dev/zero of=/tmp/test.raw bs=1 count=1234
> ./qemu-io -k -n -g -c 'read -p 1024 512' /tmp/test.raw
>
> Previously, the result of this was 'read failed: Invalid argument', now the
> read completes successfully.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> linux-aio.c | 17 ++++++++++++++---
> 1 files changed, 14 insertions(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>