[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 25/35] scsi-generic: check ioctl statuses when SG_IO
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 25/35] scsi-generic: check ioctl statuses when SG_IO succeeds |
Date: |
Thu, 13 Oct 2011 13:03:55 +0200 |
A succeeding ioctl does not imply that the SCSI command succeeded.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/scsi-generic.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index da104a6..9043eea 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -311,7 +311,7 @@ static int get_blocksize(BlockDriverState *bdrv)
io_header.timeout = 6000; /* XXX */
ret = bdrv_ioctl(bdrv, SG_IO, &io_header);
- if (ret < 0)
+ if (ret < 0 || io_header.driver_status || io_header.host_status)
return -1;
return (buf[4] << 24) | (buf[5] << 16) | (buf[6] << 8) | buf[7];
@@ -342,7 +342,7 @@ static int get_stream_blocksize(BlockDriverState *bdrv)
io_header.timeout = 6000; /* XXX */
ret = bdrv_ioctl(bdrv, SG_IO, &io_header);
- if (ret < 0)
+ if (ret < 0 || io_header.driver_status || io_header.host_status)
return -1;
return (buf[9] << 16) | (buf[10] << 8) | buf[11];
--
1.7.6
- Re: [Qemu-devel] [PATCH 11/35] scsi-disk: support READ DVD STRUCTURE, (continued)
[Qemu-devel] [PATCH 16/35] scsi: implement REPORT LUNS for arbitrary LUNs, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 18/35] scsi: add channel to addressing, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 17/35] scsi: allow arbitrary LUNs, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 22/35] scsi-disk: fix retrying a flush, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 01/35] scsi: pass correct sense code for ENOMEDIUM, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 25/35] scsi-generic: check ioctl statuses when SG_IO succeeds,
Paolo Bonzini <=
[Qemu-devel] [PATCH 24/35] scsi-generic: remove scsi_req_fixup, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 23/35] scsi-generic: drop SCSIGenericState, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 26/35] scsi-generic: look at host status, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 33/35] scsi: export scsi_generic_reqops, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 32/35] scsi: make reqops static const, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 20/35] scsi-disk: do not complete requests twice, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 19/35] scsi-disk: fail READ CAPACITY if LBA != 0 but PMI == 0, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 35/35] scsi-disk: add scsi-block for device passthrough, Paolo Bonzini, 2011/10/13