Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers

[Jan Kiszka]

On 2011-09-28 16:26, Richard Henderson wrote:
> On 09/28/2011 05:28 AM, Jan Kiszka wrote:
> > +#if TCG_TARGET_REG_BITS == 64
> > +    { INDEX_op_deposit8l_i32, { "r", "0", "r" } },
> > +#else
> > +    { INDEX_op_deposit8l_i32, { "abcd", "0", "abcd" } },
> > +#endif
>
> At minimum, abcd is spelled "q".

Ah, perfect.

> I don't particularly care for the 3 different opcodes.  Perhaps
> we'd be better off with an inline predicate for when the deposit
> opcode is "valid"?

We still need to dispatch at tcg generation time which variant is valid. 
Or what do you have in mind?

Thanks,
Jan

--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux