Re: [Qemu-devel] [PATCH] mips_malta: move i8259 initialization after piix4 initialization

[Edgar E. Iglesias]

On Wed, Sep 14, 2011 at 11:17:54PM +0300, Avi Kivity wrote:
> On 09/14/2011 07:19 PM, Andreas Färber wrote:
> >>
> >>  Can this please be reviewed?  It's in the front of the memory queue
> >>  logjam.
> >
> >With or without this patch, the mips and mipsel test images on qemu.org
> >produce no output at all, on x64 host.
> >
> 
> AFAICT this problem predates the memory API.  I'm looking more for
> criticism on the approach.

Hi, i think the images on the wiki are meant to run on a -M mips board.
Maybe the scripts predate a change to Malta as default board, don't know.

The patch looks OK to me to, but you could maybe put a comment in the code
to explain the indirection.

Cheers